Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1162843003: Add a MaskFilter interface to dart:sky to handle blur. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a MaskFilter interface to dart:sky to handle blur. For this, I added back my previous CustomDart attribute for customizing the generated Dart code of an interface. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fabb77e79e73f8f7b87b40c9de439da72bbf13ea

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -11 lines) Patch
M sky/engine/bindings/IDLExtendedAttributes.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/engine/bindings/scripts/code_generator_dart.py View 1 chunk +9 lines, -0 lines 0 comments Download
M sky/engine/bindings/scripts/templates/interface_dart.template View 4 chunks +8 lines, -5 lines 0 comments Download
M sky/engine/core/core.gni View 2 chunks +3 lines, -0 lines 0 comments Download
A sky/engine/core/painting/MaskFilter.h View 1 chunk +33 lines, -0 lines 0 comments Download
A sky/engine/core/painting/MaskFilter.cpp View 1 1 chunk +26 lines, -0 lines 0 comments Download
A sky/engine/core/painting/MaskFilter.dart View 1 chunk +27 lines, -0 lines 4 comments Download
A + sky/engine/core/painting/MaskFilter.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/core/painting/Paint.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.idl View 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/raw/painting.sky View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/raw/shadow.dart View 1 chunk +7 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Matt Perry
5 years, 6 months ago (2015-06-02 20:45:11 UTC) #2
eseidel
lgtm https://codereview.chromium.org/1162843003/diff/20001/sky/engine/core/painting/MaskFilter.dart File sky/engine/core/painting/MaskFilter.dart (right): https://codereview.chromium.org/1162843003/diff/20001/sky/engine/core/painting/MaskFilter.dart#newcode6 sky/engine/core/painting/MaskFilter.dart:6: Do we need "part dart:sky" lines at the ...
5 years, 6 months ago (2015-06-02 20:49:46 UTC) #3
Matt Perry
https://codereview.chromium.org/1162843003/diff/20001/sky/engine/core/painting/MaskFilter.dart File sky/engine/core/painting/MaskFilter.dart (right): https://codereview.chromium.org/1162843003/diff/20001/sky/engine/core/painting/MaskFilter.dart#newcode6 sky/engine/core/painting/MaskFilter.dart:6: On 2015/06/02 20:49:45, eseidel wrote: > Do we need ...
5 years, 6 months ago (2015-06-02 21:03:43 UTC) #4
Matt Perry
5 years, 6 months ago (2015-06-02 21:26:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fabb77e79e73f8f7b87b40c9de439da72bbf13ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698