Merge page serializers [2/12]

Move data url tests

Move WebPageNewSerializeTest.TestMHTMLEncodingWithDataURL and
WebPageNewSerializeTest.TestMHTMLEncodingWithMorphingDataURL test to
PageSerializerTest.

--

This review is part of set aiming to merge the two existing page
serializers, WebPageSerializerImpl and PageSerializer into the latter
one.

In addition to this it moves all the old tests from
WebPageNewSerializerTest and WebPageSerializerTest to the newer
PageSerializerTest structure and splits out a test for MHTML into the
MHTMLTest file.

Note: This is a rebase and split of
https://codereview.chromium.org/68613003 from Opera which was reverted
due to failing tests. In addition to the rebase some smaller fixes was
done to accommodate to changes in the code from when it was first
landed.

BUG=328354
R=hajimehoshi@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196695

[Tiger (Sony Mobile), 2015-06-08 10:18:35]

PTAL

[hajimehoshi, 2015-06-08 11:12:33]

https://codereview.chromium.org/1162833007/diff/1/Source/web/tests/data/pages...
File Source/web/tests/data/pageserializer/datauri/page_with_data.html (right):

https://codereview.chromium.org/1162833007/diff/1/Source/web/tests/data/pages...
Source/web/tests/data/pageserializer/datauri/page_with_data.html:8: <img
src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAAAXNSR0IArs4c6QAAAAxJREFUCNdjYGBgAAAABAABJzQnCgAAAABJRU5ErkJggg=="/>
This seems to be changed from the old one. Is this intended?

[hajimehoshi, 2015-06-08 11:13:46]

Could you please add another review? I'm not an owner.

[hajimehoshi, 2015-06-08 11:14:01]

s/review/reviewer/

[Tiger (Sony Mobile), 2015-06-08 12:49:19]

On 2015/06/08 11:13:46, hajimehoshi wrote:
> Could you please add another review? I'm not an owner.

I'll ask philipj to join in once you think it looks good.

[Tiger (Sony Mobile), 2015-06-08 12:49:26]

https://codereview.chromium.org/1162833007/diff/1/Source/web/tests/data/pages...
File Source/web/tests/data/pageserializer/datauri/page_with_data.html (right):

https://codereview.chromium.org/1162833007/diff/1/Source/web/tests/data/pages...
Source/web/tests/data/pageserializer/datauri/page_with_data.html:8: <img
src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAAAXNSR0IArs4c6QAAAAxJREFUCNdjYGBgAAAABAABJzQnCgAAAABJRU5ErkJggg=="/>
On 2015/06/08 11:12:33, hajimehoshi wrote:
> This seems to be changed from the old one. Is this intended?

Yes, it is intended. Multiple references to the same URI should not create a new
resource even for data URIs so it is an additional aspect of the test.

[hajimehoshi, 2015-06-08 18:04:12]

On 2015/06/08 12:49:26, Tiger (Sony Mobile) wrote:
>
https://codereview.chromium.org/1162833007/diff/1/Source/web/tests/data/pages...
> File Source/web/tests/data/pageserializer/datauri/page_with_data.html (right):
> 
>
https://codereview.chromium.org/1162833007/diff/1/Source/web/tests/data/pages...
> Source/web/tests/data/pageserializer/datauri/page_with_data.html:8: <img
>
src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAAAXNSR0IArs4c6QAAAAxJREFUCNdjYGBgAAAABAABJzQnCgAAAABJRU5ErkJggg=="/>
> On 2015/06/08 11:12:33, hajimehoshi wrote:
> > This seems to be changed from the old one. Is this intended?
> 
> Yes, it is intended. Multiple references to the same URI should not create a
new
> resource even for data URIs so it is an additional aspect of the test.

lgtm

[philipj_slow, 2015-06-08 19:38:13]

philipj@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2015-06-08 19:38:13]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-06-08 19:38:14]

lgtm

[commit-bot: I haz the power, 2015-06-08 19:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162833007/1

[commit-bot: I haz the power, 2015-06-08 20:55:05]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196695