Issue 1162833006: [for-in] Make ForInNext and ForInFilter deal properly with exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162833006: [for-in] Make ForInNext and ForInFilter deal properly with exceptions. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer

Modified:
5 years, 6 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[for-in] Make ForInNext and ForInFilter deal properly with exceptions. Both ToName() and HasProperty() can actually throw, so we need to propagate those exceptions properly. BUG=chromium:496331 LOG=y R=jarin@chromium.org Committed: https://crrev.com/9c41204048cf77fcc5986afb933d538a205af352 Cr-Commit-Position: refs/heads/master@{#28829}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/runtime/runtime-forin.cc	View		2 chunks	+12 lines, -4 lines	0 comments	Download

Total messages: 7 (1 generated)

Benedikt Meurer

Hey Jaro, Fix for the crashes in ForInFilter. Please take a look. Thanks, Benedikt

5 years, 6 months ago (2015-06-08 08:47:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162833006/1

5 years, 6 months ago (2015-06-08 09:18:18 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-08 10:15:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9c41204048cf77fcc5986afb933d538a205af352
Cr-Commit-Position: refs/heads/master@{#28829}