Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1162813003: Oilpan: Rename DefaultTraceTrait to AdjustAndMarkTrait (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Rename DefaultTraceTrait to AdjustAndMarkTrait What DefaultTraceTrait does is to adjust a pointer of a mixin object and call mark. It should be renamed to reflect the reality. BUG=475801 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196446

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/platform/heap/TraceTraits.h View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
PTAL
4 years, 11 months ago (2015-06-03 12:06:01 UTC) #2
keishi
lgtm
4 years, 11 months ago (2015-06-03 14:50:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162813003/20001
4 years, 11 months ago (2015-06-04 01:42:03 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 03:00:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196446

Powered by Google App Engine
This is Rietveld 408576698