Source/core/css/parser/CSSPropertyParser.cpp - Issue 1162793003: Add CSS image-orientation: from-image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1162793003: Add CSS image-orientation: from-image (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address even more review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/image-orientation/image-orientation-from-image-composited.html ('K') | « Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index e27fa5ce66af073d3b35c869321c000938253407..c4eeb14c4a1e0f007a182259e70660f24d2a180f 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -673,6 +673,9 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import

}

break;

}

+ case CSSPropertyImageOrientation:

+ validPrimitive = value->id == CSSValueFromImage || (value->unit != CSSPrimitiveValue::CSS_NUMBER && validUnit(value, FAngle) && value->fValue == 0);

+ break;

case CSSPropertyBackgroundBlendMode:

case CSSPropertyBackgroundAttachment: