LayoutTests/fast/css/image-orientation/image-orientation.html - Issue 1162793003: Add CSS image-orientation: from-image

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/image-orientation/image-orientation.html

Issue 1162793003: Add CSS image-orientation: from-image (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address even more review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt ('k') | LayoutTests/fast/css/image-orientation/image-orientation-dynamic.html » ('j') | LayoutTests/fast/css/image-orientation/image-orientation-dynamic.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description('Apply image-orientation property and check computed style.');

	9

	10 var expectations = {

	11 'from-image': ['from-image'],

	12 '0deg': ['0deg'],

	13 '': ['-360deg', '-315deg', '315deg', '360deg', '90deg', '-270deg', '-225deg' , '45deg',

	14 '180deg', '-180deg', '-135deg', '135deg', '270deg', '-90deg', '-45deg', '225 deg', '0']

	15 };

	16

	17 var p = document.createElement('p');
	Noel Gordon 2015/06/19 07:41:25 Not following: are you testing that imageOrientati Not following: are you testing that imageOrientation does not apply to <p> elements here, or did you mean to test an <img> element? rwlbuis 2015/06/19 16:03:15 It does not matter for the test from CSSComputedSt Show quoted text On 2015/06/19 07:41:25, noel gordon wrote: > Not following: are you testing that imageOrientation does not apply to <p> > elements here, or did you mean to test an <img> element? It does not matter for the test from CSSComputedStyle POV but I agree it is clearer, fixed.
	18 document.body.appendChild(p);

	19 for (expected in expectations) {

	20 expectations[expected].forEach(function(test) {

	21 p.style.imageOrientation = '';

	22 p.style.imageOrientation = test;

	23 if (expected == '') {

	24 shouldBe('p.style.cssText', '""');

	25 shouldBe('getComputedStyle(p).imageOrientation', '"0deg"');

	26 } else {

	27 shouldBe('p.style.cssText', '"image-orientation: ' + test + ';"');

	28 shouldBe('getComputedStyle(p).imageOrientation', '"' + expected + '" ');

	29 }

	30 });

	31 }

	32 document.body.removeChild(p);

	33 </script>

	34 </body>

	35 </html>

OLD	NEW