Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: public/platform/WebBlobData.h

Issue 1162773003: [Blob] Dependencies for blob storage testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebBlobData.h
diff --git a/public/platform/WebBlobData.h b/public/platform/WebBlobData.h
index fd92dffcf33d603322079a7615972e068a625ab8..742cde5727aafa4be4e39bdbcfe2ddc0cc04b0e0 100644
--- a/public/platform/WebBlobData.h
+++ b/public/platform/WebBlobData.h
@@ -48,7 +48,7 @@ class BlobData;
class WebBlobData : public WebNonCopyable {
public:
struct Item {
- enum { TypeData, TypeFile, TypeBlob, TypeFileSystemURL } type;
+ enum Type { TypeData, TypeFile, TypeBlob, TypeFileSystemURL } type;
jsbell 2015/06/02 19:30:56 Why introduce an enum name here?
dmurph 2015/06/02 20:17:41 I want to be able to use this type as a return typ
WebThreadSafeData data;
WebString blobUUID;
WebString filePath;
@@ -68,6 +68,9 @@ public:
// Retrieves the values of the item at the given index. Returns false if
// index is out of bounds.
+ // This call is single use only per index. The memory ownership is
+ // transfered to the result in the case of memory items. A second call with
+ // the same index will result in null data.
jsbell 2015/06/02 19:30:56 Maybe amend with a TODO to rework the API?
dmurph 2015/06/02 20:17:41 Done.
BLINK_PLATFORM_EXPORT bool itemAt(size_t index, Item& result) const;
BLINK_PLATFORM_EXPORT WebString contentType() const;

Powered by Google App Engine
This is Rietveld 408576698