[Blob] Dependencies for blob storage testing

public/platform/WebBlobRegistry.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebBlobRegistry_h
 #define WebBlobRegistry_h
 
 #include "WebCommon.h"
+#include "WebThreadSafeData.h"
 
 namespace blink {
 
 class WebBlobData;
 class WebString;
 class WebURL;
 
+// Acts as singleton facade for all Blob interactions ouside of blink.  This
+// includes blob:
+// * creation,
+// * reference counting,
+// * publishing, and
+// * streaming.
 class WebBlobRegistry {
 public:
+    // The blob is build in the registry on destruction of this class.
+    // Preconditions:
+    // * Not meant to be used on multiple threads.
+    // * Must not be kept alive longer than creator WebBlobRegistry (shouldn't
+    //   be an issue because of the singleton nature of the WebBlobRegistry)
+    // Calls on this object can be sending IPCs to the browser process, so make
+    // sure to destruct this ASAP.
+    class Builder {
+    public:
+        virtual ~Builder() { }

[jochen (gone - plz use gerrit), 2015/06/12 08:39:23]

not needed

[jsbell, 2015/06/12 16:43:43]

Is this for planned subclasses in unit tests on the Chromium side?

[dmurph, 2015/06/12 19:06:48]

Yes, there will be a mock subclass of this as well as the production one.

According to style guide, I need this:
http://google.github.io/styleguide/cppguide.html#Interfaces

+        virtual void appendData(const WebThreadSafeData&) = 0;
+        virtual void appendFile(const WebString& path, uint64_t offset, uint64_t length, double expectedModificationTime) = 0;
+        // Calling this method ensures the given blob lives for the creation of
+        // the new blob.
+        virtual void appendBlob(const WebString& uuid, uint64_t offset, uint64_t length) = 0;
+        virtual void appendFileSystemURL(const WebURL&, uint64_t offset, uint64_t length, double expectedModificationTime) = 0;
+    };
+
     virtual ~WebBlobRegistry() { }
 
+    // TODO(dmurph): Deprecate and migrate to createBuilder
     virtual void registerBlobData(const WebString& uuid, const WebBlobData&) { }
+
+    // Caller takes ownership of the Builder. The blob is finalized on destruction
+    // of the builder.  Append calls on the builder can be sending state over
+    // to the browser (to avoid copying), so destruct this builder ASAP.
+    virtual Builder* createBuilder(const WebString& uuid, const WebString& contentType) { BLINK_ASSERT_NOT_REACHED(); return nullptr; }
+
     virtual void addBlobDataRef(const WebString& uuid) { }
     virtual void removeBlobDataRef(const WebString& uuid) { }
     virtual void registerPublicBlobURL(const WebURL&, const WebString& uuid) { }
     virtual void revokePublicBlobURL(const WebURL&) { }
 
     // Registers a stream URL referring to a stream with the specified media
     // type.
     virtual void registerStreamURL(const WebURL&, const WebString&) { BLINK_ASSERT_NOT_REACHED(); }
 
     // Registers a stream URL referring to the stream identified by the
@@ skipping 14 matching lines @@
     // so it won't receive any more data.
     virtual void abortStream(const WebURL&) { BLINK_ASSERT_NOT_REACHED(); }
 
     // Unregisters a stream referred by the URL.
     virtual void unregisterStreamURL(const WebURL&) { BLINK_ASSERT_NOT_REACHED(); }
 };
 
 } // namespace blink
 
 #endif // WebBlobRegistry_h