Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1162763002: Revert of cc: Test BeginMainFrame values come from BeginImplFrame. (Closed)

Created:
5 years, 6 months ago by zhaoqin
Modified:
5 years, 6 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Test BeginMainFrame values come from BeginImplFrame. (patchset #3 id:40001 of https://codereview.chromium.org/1104193003/) Reason for revert: Dr.Memory bot report use-after-free error on newly added test. BUG=493852 Original issue's description: > cc: Test BeginMainFrame values come from BeginImplFrame. > > The frame time in the BeginFrameArgs sent to BeginMainFrame should match a > value from a BeginImplFrame. However there is not a 1:1 relantionship, when the > main thread is slow, there many be multiple impl frames. > > DEPS=http://crrev.com/787763006 > BUG=346230 > R=brianderson,enne > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/3785ebac79741ebc1428c9c50a8cd4bc92f0e924 > Cr-Commit-Position: refs/heads/master@{#331933} TBR=brianderson@chromium.org,enne@chromium.org,mithro@mithis.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346230 Committed: https://crrev.com/46d0e21826b581934c8f06f379cacb3b9fd2d740 Cr-Commit-Position: refs/heads/master@{#332037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -64 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +1 line, -64 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhaoqin
Created Revert of cc: Test BeginMainFrame values come from BeginImplFrame.
5 years, 6 months ago (2015-05-29 20:27:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162763002/1
5 years, 6 months ago (2015-05-29 20:28:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 20:30:15 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 20:32:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46d0e21826b581934c8f06f379cacb3b9fd2d740
Cr-Commit-Position: refs/heads/master@{#332037}

Powered by Google App Engine
This is Rietveld 408576698