Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1162753003: Revert "Implement timers by posting delayed tasks" (Closed)

Created:
5 years, 6 months ago by mnaganov (inactive)
Modified:
5 years, 6 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, falken, dglazkov+blink, gavinp+loader_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, Nate Chapin
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert "Implement timers by posting delayed tasks" This reverts commit 334040f6e54d29d7890b6f409354cd234b29c24b. Reason: Breaks GN test: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/93666/steps/html_viewer_unittests%20%28with%20patch%29/logs/stdio These tests are only built on GN bots, which absent on Blink canary waterfall. BUG=463143, 416362, 480522 TBR=jochen@chromium.org,kinuko@chromium.org,skyostil@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+797 lines, -291 lines) Patch
M Source/core/Init.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 5 chunks +102 lines, -0 lines 0 comments Download
A + Source/platform/PlatformThreadData.h View 1 chunk +16 lines, -16 lines 0 comments Download
A + Source/platform/PlatformThreadData.cpp View 1 chunk +18 lines, -9 lines 0 comments Download
A + Source/platform/SharedTimer.h View 1 chunk +38 lines, -20 lines 0 comments Download
A + Source/platform/SharedTimer.cpp View 1 chunk +11 lines, -10 lines 0 comments Download
A + Source/platform/ThreadTimers.h View 1 chunk +30 lines, -12 lines 0 comments Download
A Source/platform/ThreadTimers.cpp View 1 chunk +153 lines, -0 lines 0 comments Download
M Source/platform/Timer.h View 4 chunks +26 lines, -9 lines 0 comments Download
M Source/platform/Timer.cpp View 6 chunks +322 lines, -34 lines 0 comments Download
M Source/platform/TimerTest.cpp View 7 chunks +52 lines, -104 lines 0 comments Download
M Source/platform/blink_platform.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableAreaTest.cpp View 3 chunks +3 lines, -68 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/platform/Platform.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
Committed patchset #1 (id:1) manually as 196169 (presubmit successful).
5 years, 6 months ago (2015-05-29 21:00:52 UTC) #1
mnaganov (inactive)
5 years, 6 months ago (2015-05-29 21:06:02 UTC) #2
Message was sent while issue was closed.
Apologies, I've made a typo: should read "Breaks Mojo test". And I verified
locally that reverting the patch actually fixes the test.

On Fri, May 29, 2015 at 2:00 PM, 'mnaganov' via codereview.chromium.org <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Reviewers: jochen, kinuko, Sami,
>
> Message:
> Committed patchset #1 (id:1) manually as 196169 (presubmit successful).
>
> Description:
> Revert "Implement timers by posting delayed tasks"
>
> This reverts commit 334040f6e54d29d7890b6f409354cd234b29c24b.
>
> Reason: Breaks GN test:
>
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
>
> These tests are only built on GN bots, which absent on Blink canary
> waterfall.
>
> BUG=463143,416362,480522
> TBR=jochen@chromium.org,kinuko@chromium.org,skyostil@chromium.org
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196169
>
> Please review this at https://codereview.chromium.org/1162753003/
>
> Base URL: svn://svn.chromium.org/blink/trunk
>
> Affected files (+797, -291 lines):
>   M Source/core/Init.cpp
>   M Source/core/fetch/ResourceTest.cpp
>   M Source/core/frame/DOMTimerCoordinator.cpp
>   M Source/core/workers/WorkerThread.h
>   M Source/core/workers/WorkerThread.cpp
>   A + Source/platform/PlatformThreadData.h
>   A + Source/platform/PlatformThreadData.cpp
>   A + Source/platform/SharedTimer.h
>   A + Source/platform/SharedTimer.cpp
>   A + Source/platform/ThreadTimers.h
>   A Source/platform/ThreadTimers.cpp
>   M Source/platform/Timer.h
>   M Source/platform/Timer.cpp
>   M Source/platform/TimerTest.cpp
>   M Source/platform/blink_platform.gypi
>   M Source/platform/scroll/ScrollableAreaTest.cpp
>   M Source/web/tests/TextFinderTest.cpp
>   M public/platform/Platform.h
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698