Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 116273003: Stop recording CPU profiles when Profiler agent is disabled (Closed)

Created:
7 years ago by yurys
Modified:
7 years ago
Reviewers:
alph, aandrey, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Stop recording CPU profiles when Profiler agent is disabled Also Profiler.start command will fail unless Profiler was enabled. BUG=327298 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163962

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed test #

Total comments: 3

Patch Set 3 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -4 lines) Patch
A LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/cpu-profiler/enable-disable-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/inspector-protocol/cpu-profiler/record-cpu-profile.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 1 2 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
7 years ago (2013-12-16 12:51:23 UTC) #1
loislo
lgtm with nits https://codereview.chromium.org/116273003/diff/1/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html File LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html (right): https://codereview.chromium.org/116273003/diff/1/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html#newcode41 LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html:41: consoleProfilesAllowed(); setPassHandlers https://codereview.chromium.org/116273003/diff/1/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html#newcode71 LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html:71: consoleProfilesDisallowed(); setFailHandlers
7 years ago (2013-12-16 13:03:27 UTC) #2
aandrey
https://codereview.chromium.org/116273003/diff/20001/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html File LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html (right): https://codereview.chromium.org/116273003/diff/20001/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html#newcode87 LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html:87: Profiler.disable command will stop stop recording all profiles. stop ...
7 years ago (2013-12-16 13:05:27 UTC) #3
yurys
https://codereview.chromium.org/116273003/diff/1/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html File LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html (right): https://codereview.chromium.org/116273003/diff/1/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html#newcode41 LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html:41: consoleProfilesAllowed(); On 2013/12/16 13:03:27, loislo wrote: > setPassHandlers It ...
7 years ago (2013-12-16 14:35:08 UTC) #4
yurys
https://codereview.chromium.org/116273003/diff/20001/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html File LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html (right): https://codereview.chromium.org/116273003/diff/20001/LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html#newcode87 LayoutTests/inspector-protocol/cpu-profiler/enable-disable.html:87: Profiler.disable command will stop stop recording all profiles. On ...
7 years ago (2013-12-16 14:48:26 UTC) #5
yurys
Committed patchset #3 manually as r163962 (presubmit successful).
7 years ago (2013-12-16 14:53:53 UTC) #6
yurys
7 years ago (2013-12-16 15:17:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/101323012/ by yurys@chromium.org.

The reason for reverting is: Broke compilation on Android.

Powered by Google App Engine
This is Rietveld 408576698