Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1162723008: Add U+2212 to Japanese converters and update GBK/gb18030 aliases/tables (Closed)

Created:
5 years, 6 months ago by jungshik at Google
Modified:
5 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add U+2212 to Japanese converters and update GBK/gb18030 aliases and tables. 1. Add a one-way (encoding-only/fromUnicode) mapping for U+2212 to Shift_JIS, EUC-JP and ISO-2022-JP. The last just uses Shift_JIS. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=28661 2. Make GBK aliases list compliant to the encoding spec. 3. Add "xA3xA0 => U+3000" to the GBK (windows-936) and gb18030. This makes it possible to remove the corresponding override in Blink 4. Modify the following to GBK (windows-936). See [1] - Add U+01F9 <=> \xA8\xBF - Drop U+E7C8 <=> \xA8\xBF 5. The following change is put on hold (NOT included in the CL) until the resolution of [1] - Add U+1E3F <=> \xA8\xBC - Drop U+E7C7 <=> \xA8\xBC The corresponding Blink CL is https://codereview.chromium.org/1167523003/ [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=28740#c3 BUG=425417, 493824 TEST=Once ICU is rolled to this CL, Blink layout test fast/encoding/*. R=jsbell@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/9939a5d5314b6d59d5fb070902d73304c2482f88

Patch Set 1 #

Patch Set 2 : euc-jp, rebuilt data files #

Patch Set 3 : gbk : further changes #

Patch Set 4 : UTF-32; add MIME tag for now #

Patch Set 5 : android/win data rebuilt #

Patch Set 6 : README.chromium updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -9 lines) Patch
M README.chromium View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M android/icudtl.dat View 1 2 3 4 5 Binary file 0 comments Download
A patches/gb_table.patch View 1 2 3 4 5 1 chunk +62 lines, -0 lines 0 comments Download
M scripts/eucjp_gen.sh View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M scripts/sjis_gen.sh View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M source/data/in/icudtl.dat View 1 2 3 4 5 Binary file 0 comments Download
M source/data/mappings/convrtrs.txt View 1 2 3 4 5 3 chunks +10 lines, -6 lines 0 comments Download
M source/data/mappings/euc-jp-html.ucm View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M source/data/mappings/gb18030.ucm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/data/mappings/shift_jis-html.ucm View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M source/data/mappings/windows-936-2000.ucm View 1 2 3 4 5 4 chunks +5 lines, -2 lines 0 comments Download
M windows/icudt.dll View 1 2 3 4 5 Binary file 0 comments Download

Messages

Total messages: 7 (1 generated)
jungshik at Google
Not ready, yet. jsbell@: I wonder if you mind bundling two changes in a single ...
5 years, 6 months ago (2015-06-02 00:14:21 UTC) #2
jsbell
On 2015/06/02 00:14:21, jungshik at google wrote: > I wonder if you mind bundling two ...
5 years, 6 months ago (2015-06-02 00:16:44 UTC) #3
jungshik at Google
Now this CL is ready. Can you take a look? Thanks. #4 in the description ...
5 years, 6 months ago (2015-06-04 13:13:27 UTC) #4
jungshik at Google
On 2015/06/04 13:13:27, jungshik at google wrote: > Now this CL is ready. Can you ...
5 years, 6 months ago (2015-06-04 13:15:53 UTC) #5
jsbell
lgtm
5 years, 6 months ago (2015-06-04 17:05:42 UTC) #6
jungshik at Google
5 years, 6 months ago (2015-06-04 19:24:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:50001) manually as
9939a5d5314b6d59d5fb070902d73304c2482f88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698