Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1162693002: Revert of [Media Router] MediaRouterUI + WebUI handler implementation. (Closed)

Created:
5 years, 6 months ago by dmurph
Modified:
5 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, media-router+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] MediaRouterUI + WebUI handler implementation. (patchset #9 id:160001 of https://codereview.chromium.org/1139203003/) Reason for revert: Causing failures: https://code.google.com/p/chromium/issues/detail?id=493525 Original issue's description: > [Media Router] MediaRouterUI + WebUI handler implementation. > > This patch has two parts: > - MediaRouterWebUIMessageHandler handles calls coming > from WebUI/JS. Also sends up-to-date data (e.g. MediaSinks) > to WebUI. > - MediaRouterUI interfaces with the MediaRouter to handle calls > from the WebUI (such as CreateRoute) and listen for sink / > route updates. > > Implemented handler logic for the following from Media Router WebUI: > > OnGetInitialSettings > OnCreateRoute > OnActOnIssue - skeleton impl > OnCloseRoute > OnCloseDialog > > Implemented WebUI logic for the following (to update the UI): > UpdateSinks > UpdateRoutes > UpdateCastModes > AddRoute > UpdateIssue - skeleton impl > > Some Issues related APIs are left unimplemented until more resources > have been upstreamed. > > BUG=464216, 464208 > > Committed: https://crrev.com/bcb07449ce226e9263cf4f2637a1656377782e17 > Cr-Commit-Position: refs/heads/master@{#331905} TBR=wez@chromium.org,imcheng@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464216, 464208 Committed: https://crrev.com/9d16592929f9e12eb7d154d59fee517fcf4c917d Cr-Commit-Position: refs/heads/master@{#331919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -431 lines) Patch
M chrome/browser/ui/webui/media_router/media_router_ui.h View 2 chunks +1 line, -89 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 2 chunks +3 lines, -147 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h View 3 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 4 chunks +9 lines, -177 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmurph
Created Revert of [Media Router] MediaRouterUI + WebUI handler implementation.
5 years, 6 months ago (2015-05-29 03:13:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162693002/1
5 years, 6 months ago (2015-05-29 03:13:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 03:14:22 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 03:15:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d16592929f9e12eb7d154d59fee517fcf4c917d
Cr-Commit-Position: refs/heads/master@{#331919}

Powered by Google App Engine
This is Rietveld 408576698