chrome/browser/ui/browser.h - Issue 1162663004: Introduce browser-side plumbing for sending the lock icon status to DevTools.

Unified Diff: chrome/browser/ui/browser.h

Issue 1162663004: Introduce browser-side plumbing for sending the lock icon status to DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased onto latest master. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/connection_security_helper.cc ('K') | « chrome/browser/ssl/connection_security_helper.cc ('k') | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/browser_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.h

diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h

index 0fee68b7c1e9c9e33e3d884a9da82c28cf688834..b2346a0f76191f01db3f4d29bbaa92b74b811264 100644

--- a/chrome/browser/ui/browser.h

+++ b/chrome/browser/ui/browser.h

@@ -462,6 +462,8 @@ class Browser : public TabStripModelObserver,

bool CanDragEnter(content::WebContents* source,

const content::DropData& data,

blink::WebDragOperationsMask operations_allowed) override;

+ content::SecurityStyle GetSecurityStyle(

Peter Kasting 2015/06/03 23:59:34 Nit: GetSecurityStyleForWebContents()? Otherwise

lgarron 2015/06/04 00:26:34 "error: 'const' type qualifier on return type has

Peter Kasting 2015/06/04 00:29:15 You const-qualified the wrong thing :). I was sug

lgarron 2015/06/05 00:25:12 *shakes fist at C++* (Done. :-)

+ const content::WebContents* web_contents) override;

bool is_type_tabbed() const { return type_ == TYPE_TABBED; }

bool is_type_popup() const { return type_ == TYPE_POPUP; }