Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/compiler/verifier.cc

Issue 1162633002: [turbofan] Enforce stricter constraints on Throw nodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index d2582038ad22e1a09a49005549e2dc70921e34e4..d827f15399ac55e3c29ca63aa16beb99a73f5115 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -270,25 +270,15 @@ void Verifier::Visitor::Check(Node* node) {
CheckNotTyped(node);
break;
case IrOpcode::kDeoptimize:
- // Deoptimize uses are End.
- for (auto use : node->uses()) {
- CHECK_EQ(IrOpcode::kEnd, use->opcode());
- }
- // Type is empty.
- CheckNotTyped(node);
case IrOpcode::kReturn:
- // Return uses are End.
+ case IrOpcode::kThrow:
+ // Deoptimize, Return and Throw uses are End.
for (auto use : node->uses()) {
CHECK_EQ(IrOpcode::kEnd, use->opcode());
}
// Type is empty.
CheckNotTyped(node);
break;
- case IrOpcode::kThrow:
- // TODO(rossberg): what are the constraints on these?
- // Type is empty.
- CheckNotTyped(node);
- break;
case IrOpcode::kTerminate:
// Terminates take one loop and effect.
CHECK_EQ(1, control_count);
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698