Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 1162623007: Removed redundant rect methods on FrameView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/FindInPageCoordinates.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebRemoteFrameImpl.cpp
diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp
index 64e9f01cbc4fbdd38bcc1d0a2f92e4da2161ba8f..b8d53c8328172c5f4b9e7330bac87cb369af1030 100644
--- a/Source/web/WebRemoteFrameImpl.cpp
+++ b/Source/web/WebRemoteFrameImpl.cpp
@@ -764,9 +764,13 @@ void WebRemoteFrameImpl::initializeFromFrame(WebLocalFrame* source) const
{
ASSERT(source);
WebLocalFrameImpl* localFrameImpl = toWebLocalFrameImpl(source);
+
+ // TODO(bokan): The scale_factor argument here used to be the now-removed
+ // FrameView::visibleContentScaleFactor but the callee uses this parameter
+ // to set the device scale factor. crbug.com/493262
client()->initializeChildFrame(
localFrameImpl->frame()->view()->frameRect(),
- localFrameImpl->frame()->view()->visibleContentScaleFactor());
+ 1);
}
void WebRemoteFrameImpl::setReplicatedOrigin(const WebSecurityOrigin& origin) const
« no previous file with comments | « Source/web/FindInPageCoordinates.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698