Source/core/paint/BoxPainter.cpp - Issue 1162623007: Removed redundant rect methods on FrameView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/BoxPainter.cpp

Issue 1162623007: Removed redundant rect methods on FrameView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/paint/BoxPainter.cpp

diff --git a/Source/core/paint/BoxPainter.cpp b/Source/core/paint/BoxPainter.cpp

index 4b8298c32d0e443b430e42306c7257abb1da8df0..e002869ea73c9716d812a35bc9139d9d87b8847e 100644

--- a/Source/core/paint/BoxPainter.cpp

+++ b/Source/core/paint/BoxPainter.cpp

@@ -742,7 +742,7 @@ void BoxPainter::calculateBackgroundImageGeometry(LayoutBoxModelObject& obj, con

if (fixedBackgroundPaintsInLocalCoordinates(obj))

viewportRect.setLocation(IntPoint());

else if (FrameView* frameView = obj.view()->frameView())

- viewportRect.setLocation(IntPoint(frameView->scrollOffsetForViewportConstrainedObjects()));

+ viewportRect.setLocation(frameView->scrollPosition());

if (paintContainer) {

IntPoint absoluteContainerOffset = roundedIntPoint(paintContainer->localToAbsolute(FloatPoint()));