Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1162623007: Removed redundant rect methods on FrameView (Closed)

Created:
5 years, 6 months ago by bokan
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, dcheng, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removed redundant rect methods on FrameView Removed visibleContentScaleFactor and any methods related to page scale since this is no longer done in FrameView. I also removed viewportConstrainedVisibleContentRect as it's effectively the same as visibleContentRect. Similarly for scrollOffsetForViewportConstrainedObjects. BUG=404284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196356

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -80 lines) Patch
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.h View 5 chunks +8 lines, -18 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 10 chunks +9 lines, -37 lines 0 comments Download
M Source/core/frame/PinchViewport.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBox.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/FindInPageCoordinates.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bokan
Hi Levi, small cleanup, ptal.
5 years, 6 months ago (2015-05-29 13:38:37 UTC) #3
bokan
On 2015/05/29 13:38:37, bokan wrote: > Hi Levi, small cleanup, ptal. Ping
5 years, 6 months ago (2015-06-02 10:41:19 UTC) #4
leviw_travelin_and_unemployed
Much LGTM! Such Simplification! Wow!
5 years, 6 months ago (2015-06-02 22:14:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162623007/20001
5 years, 6 months ago (2015-06-02 22:14:40 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 23:33:15 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196356

Powered by Google App Engine
This is Rietveld 408576698