Enable template checking for the clang plugin on Android.

Enable template checking for the clang plugin on Android.

This enables the plugin to check templated classes for the following
things:
- Refcounted types have private destructors.
- WeakPtrFactory members are the last members

BUG=441916
Committed: https://crrev.com/b0dad9e37be79905855ac637a041429775582edd
Cr-Commit-Position: refs/heads/master@{#331907}

[dcheng, 2015-05-28 17:18:13]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2015-05-28 17:18:13]

It built locally after I synced ~10 minutes ago. I plan on git cl landing this.

I guess I could just try enabling it everywhere in one go, but this seems a bit
safer.

[Nico, 2015-05-28 17:24:13]

lgtm, but why not land through the cq? should be pretty fast these days

(did you try putting some code that's only warned about with this flag in some
TU and check it's indeed warned about? it's surprising that this Just Works
everywhere)

[dcheng, 2015-05-28 20:47:56]

OK, so it turns out the CL description isn't completely accurate. We're not yet
checking virtual/override on templated classes yet.

I think it's probably still worth going ahead with this so we can remove the
template flag for non-public dtors for refcounted objects and WeakPtrFactory
ordering. After this is done for all platforms, I can take another look at
virtual/override on templates.

[dcheng, 2015-05-29 00:34:20]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-05-29 00:35:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162623003/1

[commit-bot: I haz the power, 2015-05-29 01:40:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-29 01:41:49]

Patchset 1 (id:??) landed as
https://crrev.com/b0dad9e37be79905855ac637a041429775582edd
Cr-Commit-Position: refs/heads/master@{#331907}

[dmurph, 2015-05-29 05:08:09]

On 2015/05/29 at 01:41:49, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/b0dad9e37be79905855ac637a041429775582edd
> Cr-Commit-Position: refs/heads/master@{#331907}

Any chance this is causing our clang issues here:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

[dcheng, 2015-05-29 05:16:48]

On 2015/05/29 at 05:08:09, dmurph wrote:
> On 2015/05/29 at 01:41:49, commit-bot wrote:
> > Patchset 1 (id:??) landed as
https://crrev.com/b0dad9e37be79905855ac637a041429775582edd
> > Cr-Commit-Position: refs/heads/master@{#331907}
> 
> Any chance this is causing our clang issues here:
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

That breakage is due to https://codereview.chromium.org/1084173004, which
changed the definition of SwapCompletionCallback:
typedef base::Callback<void(gfx::SwapResult)> SwapCompletionCallback;