base/test/icu_test_util.cc - Issue 1162603004: Restore locales after tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/test/icu_test_util.cc

Issue 1162603004: Restore locales after tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Errors fixed Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/i18n/rtl.h"
	Mark Mentovai 2015/08/19 13:37:15 #include icu_test_util.h first, because it’s assoc #include icu_test_util.h first, because it’s associated with this file. Then, leave a blank line and have the other two #includes.
	6 #include "base/test/icu_test_util.h"

	7 #include "third_party/icu/source/common/unicode/uloc.h"

	8

	9 namespace base {

	10

	11 ScopedSetICUDefaultLocale::ScopedSetICUDefaultLocale() {

	12 default_locale_ = uloc_getDefault();
	Mark Mentovai 2015/08/19 13:37:15 Use initializer format instead for constructors wh Use initializer format instead for constructors when possible: ScopedSetICUDefaultLocale::ScopedSetICUDefaultLocale() : default_locale_(uloc_getDefault()) { }
	13 }

	14

	15 ScopedSetICUDefaultLocale::~ScopedSetICUDefaultLocale() {

	16 i18n::SetICUDefaultLocale(default_locale_.data());

	17 }

	18 } // namespace base
	Mark Mentovai 2015/08/19 13:37:15 Blank line before this. Blank line before this.
OLD	NEW

« base/test/icu_test_util.h ('K') | « base/test/icu_test_util.h ('k') | no next file » | no next file with comments »