Issue 1162583002: Use begin/end istead of first/last for rule ranges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162583002: Use begin/end istead of first/last for rule ranges. (Closed)

Created:
5 years, 6 months ago by rune

Modified:
5 years, 6 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

Use begin/end istead of first/last for rule ranges. MatchResult used -1 for empty ranges of matched properties. Use begin/end instead where begin == end means we have an empty range. As requested in https://codereview.chromium.org/1155393002/ R=timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196065

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -25 lines)			Patch
M	Source/core/css/ElementRuleCollector.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/MatchResult.h	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	6 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162583002/1

5 years, 6 months ago (2015-05-28 13:22:50 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-05-28 14:20:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196065