Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: third_party/polymer/v0_8/components-chromium/paper-input/paper-input-char-counter-extracted.js

Issue 1162563004: Upgrade to 1.0 and switch clients to dom-repeat where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a layout import and remove the gzipped webanimation in reproduce.sh Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v0_8/components-chromium/paper-input/paper-input-char-counter-extracted.js
diff --git a/third_party/polymer/v0_8/components-chromium/paper-input/paper-input-char-counter-extracted.js b/third_party/polymer/v0_8/components-chromium/paper-input/paper-input-char-counter-extracted.js
index ad120f8a9cafe6a493251cd39725bde1d6de954b..673f5e79bf900bea273f12f1a0569048f6213f9b 100644
--- a/third_party/polymer/v0_8/components-chromium/paper-input/paper-input-char-counter-extracted.js
+++ b/third_party/polymer/v0_8/components-chromium/paper-input/paper-input-char-counter-extracted.js
@@ -6,48 +6,33 @@
is: 'paper-input-char-counter',
- enableCustomStyleProperties: true,
-
- hostAttributes: {
- 'add-on': ''
- },
+ behaviors: [
+ Polymer.PaperInputAddonBehavior
+ ],
properties: {
- /**
- * The associated input element.
- */
- inputElement: {
- type: Object
- },
-
- /**
- * The current value of the input element.
- */
- value: {
- type: String
- },
-
- /**
- * The character counter string.
- */
- charCounter: {
- computed: '_computeCharCounter(inputElement,value)',
- type: String
+ _charCounterStr: {
+ type: String,
+ value: '0'
}
},
- attached: function() {
- this.fire('addon-attached');
- },
+ update: function(state) {
+ if (!state.inputElement) {
+ return;
+ }
+
+ state.value = state.value || '';
+
+ // Account for the textarea's new lines.
+ var str = state.value.replace(/(\r\n|\n|\r)/g, '--').length;
- _computeCharCounter: function(inputElement,value) {
- var str = value.length;
- if (inputElement.hasAttribute('maxlength')) {
- str += '/' + inputElement.maxLength;
+ if (state.inputElement.hasAttribute('maxlength')) {
+ str += '/' + state.inputElement.getAttribute('maxlength');
}
- return str;
+ this._charCounterStr = str;
}
});

Powered by Google App Engine
This is Rietveld 408576698