Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1162483002: Revert of Correctly set ScriptState in the image loader microtask (Closed)

Created:
5 years, 6 months ago by dmurph
Modified:
5 years, 6 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Correctly set ScriptState in the image loader microtask (patchset #1 id:1 of https://codereview.chromium.org/1153233002/) Reason for revert: Tree on failure, might be causing the issues w/ leaking https://code.google.com/p/chromium/issues/detail?id=492829&thanks=492829&ts=1432760699 Original issue's description: > Correctly set ScriptState in the image loader microtask > > BUG=487155 > R=haraken@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195981 TBR=haraken@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487155 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M Source/core/dom/Microtask.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmurph
Created Revert of Correctly set ScriptState in the image loader microtask
5 years, 6 months ago (2015-05-27 21:05:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162483002/1
5 years, 6 months ago (2015-05-27 21:23:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196007
5 years, 6 months ago (2015-05-27 21:24:46 UTC) #3
haraken
5 years, 6 months ago (2015-05-27 23:14:12 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698