Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1162453003: Remove rendundant ../include from paths of files in include/ directory (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove rendundant ../include from paths of files in include/ directory Tiny bit of tidying I noticed while trying to figure out include rules. In other words, cd core/include git grep 'include.*include' git grep 'include.*src' Should produce no output, and cd fpdfsdk/include git grep 'include.*include' | grep -v ../core/include git grep 'include.*src' Should produce no output as well. Fix some IWYU, header guards, include ordering, whitespace along the way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/14f57a153dcbc4c5fedeffe12a3b4f915cc5d558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -90 lines) Patch
M core/include/fdrm/fx_crypt.h View 2 chunks +10 lines, -4 lines 0 comments Download
M core/include/fpdfapi/fpdfapi.h View 1 chunk +7 lines, -5 lines 0 comments Download
M core/include/fxge/fx_font.h View 2 chunks +7 lines, -8 lines 0 comments Download
M fpdfsdk/include/formfiller/FormFiller.h View 1 chunk +8 lines, -20 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JavaScript.h View 1 chunk +16 lines, -29 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PDFWindow.h View 1 chunk +10 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, quick tidying.
5 years, 6 months ago (2015-05-27 21:15:17 UTC) #2
Lei Zhang
lgtm
5 years, 6 months ago (2015-05-27 23:00:33 UTC) #3
Tom Sepez
5 years, 6 months ago (2015-05-27 23:07:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14f57a153dcbc4c5fedeffe12a3b4f915cc5d558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698