[sync] Componentize sync: Part 6: Add more SYNC_EXPORTs to files in src/sync/

sync/internal_api/public/util/weak_handle.h

Index: sync/internal_api/public/util/weak_handle.h
diff --git a/sync/internal_api/public/util/weak_handle.h b/sync/internal_api/public/util/weak_handle.h
index bac7c379230f5e23886b78a35eb45f1810554a0e..57a44bd03b02f35242ca3f1eeac3daf866872cc3 100644
--- a/sync/internal_api/public/util/weak_handle.h
+++ b/sync/internal_api/public/util/weak_handle.h
@@ -58,6 +58,7 @@
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
+#include "sync/base/sync_export.h"
 
 namespace base {
 class MessageLoopProxy;
@@ -99,7 +100,7 @@ struct ParamTraits<T[]> {
 
 // Base class for WeakHandleCore<T> to avoid template bloat.  Handles
 // the interaction with the owner thread and its message loop.
-class WeakHandleCoreBase {
+class SYNC_EXPORT WeakHandleCoreBase {
  public:
   // Assumes the current thread is the owner thread.
   WeakHandleCoreBase();
@@ -125,7 +126,7 @@ class WeakHandleCoreBase {
 // WeakHandleCore<T> contains all the logic for WeakHandle<T>.
 template <typename T>
 class WeakHandleCore
-    : public NON_EXPORTED_BASE(WeakHandleCoreBase),

[rlarocque, 2012/12/22 02:00:49]

It seems like this change goes against the original author's intent.  Why won't
this work as written?

[Raghu Simha, 2012/12/22 02:25:02]

I agree. Perhaps the error I saw had to do with the non-virtual destructor. I've
restored this like to what it was.

[akalin, 2012/12/26 09:39:57]

Hmm, I still think this is correct.  Template classes don't need export
declarations since they're templated, but all these inherit from a single
internal class, which shouldn't need to be exported, and NON_EXPORTED_BASE is to
suppress the warning this produces in MSVC.

+    : public WeakHandleCoreBase,
       public base::RefCountedThreadSafe<WeakHandleCore<T> > {
  public:
   // Must be called on |ptr|'s owner thread, which is assumed to be