Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: sync/notifier/p2p_invalidator.h

Issue 11624037: [sync] Componentize sync: Part 6: Add more SYNC_EXPORTs to files in src/sync/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase (no code changes) Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/object_id_invalidation_map.h ('k') | sync/notifier/push_client_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/p2p_invalidator.h
diff --git a/sync/notifier/p2p_invalidator.h b/sync/notifier/p2p_invalidator.h
index 9f3df2c29f20bafd3a2e5eb069f89cad66ab7562..9bb28a57e3cf546b92b591872e328c963119f4c7 100644
--- a/sync/notifier/p2p_invalidator.h
+++ b/sync/notifier/p2p_invalidator.h
@@ -30,7 +30,7 @@ class PushClient;
namespace syncer {
// The channel to use for sync notifications.
-SYNC_EXPORT_PRIVATE extern const char kSyncP2PNotificationChannel[];
+SYNC_EXPORT extern const char kSyncP2PNotificationChannel[];
// The intended recipient(s) of a P2P notification.
enum P2PNotificationTarget {
@@ -41,11 +41,11 @@ enum P2PNotificationTarget {
LAST_NOTIFICATION_TARGET = NOTIFY_ALL
};
-std::string P2PNotificationTargetToString(
+SYNC_EXPORT_PRIVATE std::string P2PNotificationTargetToString(
P2PNotificationTarget target);
// If |target_str| can't be parsed, assumes NOTIFY_SELF.
-P2PNotificationTarget P2PNotificationTargetFromString(
+SYNC_EXPORT_PRIVATE P2PNotificationTarget P2PNotificationTargetFromString(
const std::string& target_str);
// Helper notification data class that can be serialized to and
@@ -88,8 +88,9 @@ class SYNC_EXPORT_PRIVATE P2PNotificationData {
IncomingInvalidationSource source_;
};
-class P2PInvalidator : public Invalidator,
- public notifier::PushClientObserver {
+class SYNC_EXPORT_PRIVATE P2PInvalidator
+ : public Invalidator,
+ public NON_EXPORTED_BASE(notifier::PushClientObserver) {
public:
// The |send_notification_target| parameter was added to allow us to send
// self-notifications in some cases, but not others. The value should be
« no previous file with comments | « sync/notifier/object_id_invalidation_map.h ('k') | sync/notifier/push_client_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698