Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: sync/internal_api/public/http_bridge.h

Issue 11624037: [sync] Componentize sync: Part 6: Add more SYNC_EXPORTs to files in src/sync/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase (no code changes) Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/http_bridge.h
diff --git a/sync/internal_api/public/http_bridge.h b/sync/internal_api/public/http_bridge.h
index 880c588ae85b3d41517d2015ceb2266e9d203212..470c1c6affe560008b9b62fb30b973e164f63db1 100644
--- a/sync/internal_api/public/http_bridge.h
+++ b/sync/internal_api/public/http_bridge.h
@@ -38,10 +38,13 @@ namespace syncer {
// This is a one-time use bridge. Create one for each request you want to make.
// It is RefCountedThreadSafe because it can PostTask to the io loop, and thus
// needs to stick around across context switches, etc.
-class HttpBridge : public base::RefCountedThreadSafe<HttpBridge>,
- public HttpPostProviderInterface,
- public net::URLFetcherDelegate {
+class SYNC_EXPORT_PRIVATE HttpBridge
+ : public base::RefCountedThreadSafe<HttpBridge>,
+ public HttpPostProviderInterface,
+ public net::URLFetcherDelegate {
public:
+ friend class SyncHttpBridgeTest;
+
// A request context used for HTTP requests bridged from the sync backend.
// A bridged RequestContext has a dedicated in-memory cookie store and does
// not use a cache. Thus the same type can be used for incognito mode.
@@ -69,7 +72,8 @@ class HttpBridge : public base::RefCountedThreadSafe<HttpBridge>,
};
// Lazy-getter for RequestContext objects.
- class RequestContextGetter : public net::URLRequestContextGetter {
+ class SYNC_EXPORT_PRIVATE RequestContextGetter
+ : public net::URLRequestContextGetter {
public:
RequestContextGetter(
net::URLRequestContextGetter* baseline_context_getter,
@@ -118,11 +122,7 @@ class HttpBridge : public base::RefCountedThreadSafe<HttpBridge>,
// net::URLFetcherDelegate implementation.
virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
-#if defined(UNIT_TEST)
- net::URLRequestContextGetter* GetRequestContextGetter() const {
- return context_getter_for_request_;
- }
-#endif
+ net::URLRequestContextGetter* GetRequestContextGetterForTest() const;
protected:
friend class base::RefCountedThreadSafe<HttpBridge>;
« no previous file with comments | « sync/internal_api/public/engine/polling_constants.h ('k') | sync/internal_api/public/http_post_provider_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698