[sync] Componentize sync: Part 6: Add more SYNC_EXPORTs to files in src/sync/

sync/internal_api/public/base/invalidation.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_INVALIDATION_H_
 #define SYNC_INTERNAL_API_PUBLIC_BASE_INVALIDATION_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 14 matching lines @@
   static AckHandle CreateUnique();
   static AckHandle InvalidAckHandle();
 
   bool Equals(const AckHandle& other) const;
 
   scoped_ptr<base::DictionaryValue> ToValue() const;
   bool ResetFromValue(const base::DictionaryValue& value);
 
   bool IsValid() const;
 
+  virtual ~AckHandle();

[akalin, 2012/12/27 19:48:52]

hunh, why is this necessary?  Nothing inherits from AckHandle, right?

[Raghu Simha, 2013/01/02 06:49:24]

You're right that the destructors don't have to be virtual. However, not adding
them at all results in a LNK2005 (multiply defined symbol) error because the
compiler automatically defines the destructors in the components that include
this header. I've made the destructor non-virtual.

+
  private:
   // Explicitly copyable and assignable for STL containers.
   AckHandle(const std::string& state, base::Time timestamp);
 
   std::string state_;
   base::Time timestamp_;
 };
 
 // Represents a local invalidation, and is roughly analogous to
 // invalidation::Invalidation. It contains a payload (which may be empty) and an
 // associated ack handle that an InvalidationHandler implementation can use to
 // acknowledge receipt of the invalidation. It does not embed the object ID,
 // since it is typically associated with it through ObjectIdInvalidationMap.
-struct Invalidation {
+struct SYNC_EXPORT Invalidation {
   Invalidation();
+  virtual ~Invalidation();

[akalin, 2012/12/27 19:48:52]

here, too

[Raghu Simha, 2013/01/02 06:49:24]

Made this non-virtual too.

 
   bool Equals(const Invalidation& other) const;
 
   scoped_ptr<base::DictionaryValue> ToValue() const;
   bool ResetFromValue(const base::DictionaryValue& value);
 
   std::string payload;
   AckHandle ack_handle;
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_BASE_INVALIDATION_H_