chrome/browser/extensions/api/management/management_api.cc - Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/extension_context_menu_model.cc » ('j') | chrome/common/extensions/manifest_url_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 16584f1161ac84ac275d7525c640f4932f004a4b..7aba60637ee8c43d8f79f8212e9ceb9d4073b4a4 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -33,6 +33,7 @@

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_icon_set.h"

+#include "chrome/common/extensions/manifest_url_handler.h"

#include "chrome/common/extensions/permissions/permission_set.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_source.h"

@@ -98,7 +99,7 @@ scoped_ptr<management::ExtensionInfo> CreateExtensionInfo(

info->description = extension.description();

info->options_url = extension.options_url().spec();

info->homepage_url.reset(new std::string(

- extension.GetHomepageURL().spec()));

+ extensions::ManifestURL::GetHomepageURL(&extension).spec()));

info->may_disable = system->management_policy()->

UserMayModifySettings(&extension, NULL);

info->is_app = extension.is_app();