Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: chrome/common/extensions/manifest_url_info.h

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments addressed Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_url_info.h
diff --git a/chrome/common/extensions/manifest_url_info.h b/chrome/common/extensions/manifest_url_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..20c5cbbb2d6dc8f1403416278c36e3d17db8dc83
--- /dev/null
+++ b/chrome/common/extensions/manifest_url_info.h
@@ -0,0 +1,32 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_URL_INFO_H_
+#define CHROME_COMMON_EXTENSIONS_MANIFEST_URL_INFO_H_
+
+#include <string>
+
+#include "chrome/common/extensions/extension.h"
+
+namespace extensions {
+
+class Extension;
+
+struct ManifestURLInfo : public Extension::ManifestData {
Yoyo Zhou 2013/01/03 01:45:55 I think you could call this just ManifestURL.
Joe Thomas 2013/01/03 19:56:31 Done.
+
+ // URL parsed from the extension manifest file.
+ GURL url_;
+
+ // Get the URL associated with "devtools_page" manifest key.
+ static const GURL& GetDevToolsPage(const Extension* extension);
+
+ // Returns the Homepage URL for this extension. If homepage_url was not
+ // specified in the manifest, this returns the Google Gallery URL. For
+ // third-party extensions, this returns a blank GURL.
+ static const GURL GetHomepageURL(const Extension* extension);
+};
+
+} // namespace extensions
+
+#endif // CHROME_COMMON_EXTENSIONS_MANIFEST_URL_INFO_H_

Powered by Google App Engine
This is Rietveld 408576698