chrome/chrome_common.gypi - Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_dependency_manager.cc ('K') | « chrome/chrome_browser_extensions.gypi ('k') | chrome/common/extensions/devtools_page_handler.h » ('j') | chrome/common/extensions/devtools_page_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 2f715b56695cdd6a9e7f859bf9358549438c8915..61776f46432f3bc081772757656feaa9cbd64ba7 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -130,6 +130,8 @@

'common/extensions/command.h',

'common/extensions/csp_validator.cc',

'common/extensions/csp_validator.h',

+ 'common/extensions/devtools_page_handler.cc',

+ 'common/extensions/devtools_page_handler.h',

'common/extensions/draggable_region.cc',

'common/extensions/draggable_region.h',

'common/extensions/event_filter.cc',

@@ -175,10 +177,14 @@

'common/extensions/features/permission_feature.h',

'common/extensions/features/simple_feature.cc',

'common/extensions/features/simple_feature.h',

+ 'common/extensions/homepage_url_handler.cc',

+ 'common/extensions/homepage_url_handler.h',

'common/extensions/manifest.cc',

'common/extensions/manifest.h',

'common/extensions/manifest_handler.cc',

'common/extensions/manifest_handler.h',

+ 'common/extensions/manifest_url_info.cc',

+ 'common/extensions/manifest_url_info.h',

'common/extensions/matcher/regex_set_matcher.cc',

'common/extensions/matcher/regex_set_matcher.h',

'common/extensions/matcher/string_pattern.cc',