chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_dependency_manager.cc ('K') | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | chrome/common/extensions/devtools_page_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 90712947cf3d6c9d0ca1a92e43a5ba92986b041a..4f7de1028a51980abe6027354e9f7f4d9a0ee01b 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -47,6 +47,7 @@

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/extension_set.h"

#include "chrome/common/extensions/feature_switch.h"

+#include "chrome/common/extensions/manifest_url_info.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/notification_service.h"

@@ -72,6 +73,7 @@ using extensions::Extension;

using extensions::ExtensionUpdater;

using extensions::ExtensionWarning;

using extensions::ManagementPolicy;

+using extensions::ManifestURLInfo;

///////////////////////////////////////////////////////////////////////////////

@@ -150,7 +152,7 @@ DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(

extension_data->SetBoolean("is_hosted_app", extension->is_hosted_app());

extension_data->SetBoolean("is_platform_app", extension->is_platform_app());

extension_data->SetBoolean("homepageProvided",

- extension->GetHomepageURL().is_valid());

+ ManifestURLInfo::GetHomepageURL(extension).is_valid());

string16 automatically_disabled_text;

int disable_reasons =