Chromium Code Reviews| Index: pkg/serialization/lib/serialization.dart |
| diff --git a/pkg/serialization/lib/serialization.dart b/pkg/serialization/lib/serialization.dart |
| index 1fedea882fea42e649a090ca819e1f1645f41ba9..dd8722ec2f121b8eaf678ace04fad203a3c62bcf 100644 |
| --- a/pkg/serialization/lib/serialization.dart |
| +++ b/pkg/serialization/lib/serialization.dart |
| @@ -45,7 +45,9 @@ |
| * excludeFields: ["other", "stuff"]); |
| * |
| * We can also use a completely non-reflective rule to serialize and |
| - * de-serialize objects. |
| + * de-serialize objects. This can be more work for us, but can run via |
|
sethladd
2012/12/22 00:06:24
What do you mean "us" here?
perhaps, "This techni
Alan Knight
2012/12/22 00:31:21
Done.
|
| + * dart2js where mirrors are not yet implemented, and even on the VM may |
| + * have better performance. |
| * |
| * addressToMap(a) => {"number" : a.number, "street" : a.street, |
| * "city" : a.city}; |
| @@ -231,7 +233,9 @@ class Serialization { |
| * [instanceOfType]. Optionally |
| * allows specifying a [constructor] name, the list of [constructorFields], |
| * and the list of [fields] not used in the constructor. Returns the new |
| - * rule. |
| + * rule. Note that [BasicRule] uses reflection, and so will not work with the |
| + * current state of dartj2s. If you need to run there, consider using |
| + * [CustomRule] instead. |
| * |
| * If the optional parameters aren't specified, the default constructor will |
| * be used, and the list of fields will be computed. Alternatively, you can |