Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: pkg/serialization/lib/serialization.dart

Issue 11624031: Fix documentation bugs 7517 and 7518 in serialization. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/serialization/lib/src/reader_writer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/serialization/lib/serialization.dart
diff --git a/pkg/serialization/lib/serialization.dart b/pkg/serialization/lib/serialization.dart
index 1fedea882fea42e649a090ca819e1f1645f41ba9..dd8722ec2f121b8eaf678ace04fad203a3c62bcf 100644
--- a/pkg/serialization/lib/serialization.dart
+++ b/pkg/serialization/lib/serialization.dart
@@ -45,7 +45,9 @@
* excludeFields: ["other", "stuff"]);
*
* We can also use a completely non-reflective rule to serialize and
- * de-serialize objects.
+ * de-serialize objects. This can be more work for us, but can run via
sethladd 2012/12/22 00:06:24 What do you mean "us" here? perhaps, "This techni
Alan Knight 2012/12/22 00:31:21 Done.
+ * dart2js where mirrors are not yet implemented, and even on the VM may
+ * have better performance.
*
* addressToMap(a) => {"number" : a.number, "street" : a.street,
* "city" : a.city};
@@ -231,7 +233,9 @@ class Serialization {
* [instanceOfType]. Optionally
* allows specifying a [constructor] name, the list of [constructorFields],
* and the list of [fields] not used in the constructor. Returns the new
- * rule.
+ * rule. Note that [BasicRule] uses reflection, and so will not work with the
+ * current state of dartj2s. If you need to run there, consider using
+ * [CustomRule] instead.
*
* If the optional parameters aren't specified, the default constructor will
* be used, and the list of fields will be computed. Alternatively, you can
« no previous file with comments | « no previous file | pkg/serialization/lib/src/reader_writer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698