Handle non-constant divisor in MathFloorOfDiv, on ia32/x64

src/ia32/lithium-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1287 matching lines @@
 }
 
 
 HValue* LChunkBuilder::SimplifiedDivisorForMathFloorOfDiv(HValue* divisor) {
   if (divisor->IsConstant() &&
       HConstant::cast(divisor)->HasInteger32Value()) {
     HConstant* constant_val = HConstant::cast(divisor);
     return constant_val->CopyToRepresentation(Representation::Integer32(),
                                               divisor->block()->zone());
   }
+  // A value with an integer representation does not need to be transformed.
+  if (divisor->representation().IsInteger32())

[Yang, 2012/12/27 14:41:53]

For if-else, we always insert brackets.

+    return divisor;

[Yang, 2012/12/27 14:41:53]

Please conform to the usual code style. Specifically, use no brackets if the if
is a one-liner, or brackets if you have line breaks.

+  // A change from an integer32 can be replaced by the integer32 value.
+  else if (divisor->IsChange() &&
+           HChange::cast(divisor)->from().IsInteger32())
+    return HChange::cast(divisor)->value();
   return NULL;
 }
 
 
 LInstruction* LChunkBuilder::DoMathFloorOfDiv(HMathFloorOfDiv* instr) {
   HValue* right = instr->right();
+  if (!right->IsConstant()) {
+    ASSERT(right->representation().IsInteger32());
+    // The temporary operand is necessary to ensure that right is not allocated
+    // into edx.
+    LOperand* temp = FixedTemp(edx);
+    LOperand* dividend = UseFixed(instr->left(), eax);
+    LOperand* divisor = UseRegister(instr->right());
+    LDivI* flooring_div = new(zone()) LDivI(dividend, divisor, temp);
+    return AssignEnvironment(DefineFixed(flooring_div, eax));
+  }
+
   ASSERT(right->IsConstant() && HConstant::cast(right)->HasInteger32Value());
   LOperand* divisor = chunk_->DefineConstantOperand(HConstant::cast(right));
   int32_t divisor_si = HConstant::cast(right)->Integer32Value();
   if (divisor_si == 0) {
     LOperand* dividend = UseRegister(instr->left());
     return AssignEnvironment(DefineAsRegister(
         new(zone()) LMathFloorOfDiv(dividend, divisor, NULL)));
   } else if (IsPowerOf2(abs(divisor_si))) {
     // use dividend as temp if divisor < 0 && divisor != -1
     LOperand* dividend = divisor_si < -1 ? UseTempRegister(instr->left()) :
@@ skipping 1154 matching lines @@
 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
   LOperand* object = UseRegister(instr->object());
   LOperand* index = UseTempRegister(instr->index());
   return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32