sdk/lib/_internal/compiler/implementation/compiler.dart - Issue 11624011: Mirrors implemented via patches. 2nd try.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 11624011: Mirrors implemented via patches. 2nd try. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Second attempt Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/compiler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/compiler.dart b/sdk/lib/_internal/compiler/implementation/compiler.dart

index 1de80f07f742a4ee91d05cf2849b3efa9db58655..1f4eb4fadc5962351a068990d5b722703a49beb9 100644

--- a/sdk/lib/_internal/compiler/implementation/compiler.dart

+++ b/sdk/lib/_internal/compiler/implementation/compiler.dart

@@ -534,19 +534,18 @@ abstract class Compiler implements DiagnosticListener {

bool nativeTest = library.entryCompilationUnit.script.name.contains(

'dart/tests/compiler/dart2js_native');

if (nativeTest

- || libraryName == 'dart:mirrors'

|| libraryName == 'dart:math'

|| libraryName == 'dart:html'

|| libraryName == 'dart:html_common'

|| libraryName == 'dart:indexed_db'

|| libraryName == 'dart:svg'

- || libraryName == 'dart:web_audio') {

+ || libraryName == 'dart:web_audio'

+ || libraryName == 'dart:mirrors') {

ahe 2012/12/19 10:37:57 Perhaps you shouldn't move this line.

if (nativeTest

|| libraryName == 'dart:html'

|| libraryName == 'dart:html_common'

|| libraryName == 'dart:indexed_db'

- || libraryName == 'dart:svg'

- || libraryName == 'dart:mirrors') {

+ || libraryName == 'dart:svg') {

// dart:html and dart:svg need access to convertDartClosureToJS and

// annotation classes.

// dart:mirrors needs access to the Primitives class.