chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm - Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile in test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm ('k') | chrome/browser/ui/cocoa/info_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

index 8ea677543ff6400d9fba382e9c3876c2f0d05b6d..597c488c3984abbaf66f1e1b714b99fb387e1286 100644

--- a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

@@ -76,7 +76,7 @@ BOOL g_animations_enabled = false;

ui::NativeTheme* nativeTheme = ui::NativeTheme::instance();

[[self bubble] setAlignment:info_bubble::kAlignArrowToAnchor];

- [[self bubble] setArrowLocation:info_bubble::kTopRight];

+ [[self bubble] setArrowLocation:views::BubbleBorder::TOP_RIGHT];

[[self bubble] setBackgroundColor:

gfx::SkColorToCalibratedNSColor(nativeTheme->GetSystemColor(

ui::NativeTheme::kColorId_DialogBackground))];

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm ('k') | chrome/browser/ui/cocoa/info_bubble_view.h » ('j') | no next file with comments »