chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile in test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 1d56a8cf2826efc5334b0001fef320a9187cd707..e56eccbdc5f49d3a9f40a8f6fb2434767d1d62d0 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -307,9 +307,9 @@ bool ExtensionInstalledBubbleBridge::MaybeShowNow() {

NSWindow* window = [self window]; // completes nib load

if (type_ == extension_installed_bubble::kOmniboxKeyword) {

- [self.bubble setArrowLocation:info_bubble::kTopLeft];

+ [self.bubble setArrowLocation:views::BubbleBorder::TOP_LEFT];

} else {

- [self.bubble setArrowLocation:info_bubble::kTopRight];

+ [self.bubble setArrowLocation:views::BubbleBorder::TOP_RIGHT];

}

if (type_ == extension_installed_bubble::kBundle)