chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm - Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile in test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm ('k') | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm b/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

index b9d8b0c9ce5b28fe6bfd9fad9b4017a23465b5d0..57595b8fbc4a92baaad7eed336930a3ef30275ac 100644

--- a/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm

@@ -213,14 +213,15 @@ void NewCreditCardBubbleCocoa::Show() {

anchor_point = NSMakePoint(

NSMidX([anchor_view bounds]),

NSMinY([anchor_view bounds]) + kWrenchBubblePointOffsetY);

- [[bubbleController_ bubble] setArrowLocation:info_bubble::kTopRight];

+ [[bubbleController_ bubble]

+ setArrowLocation:views::BubbleBorder::TOP_RIGHT];

[[bubbleController_ bubble] setAlignment:info_bubble::kAlignArrowToAnchor];

} else {

anchor_view = browser_view;

anchor_point = NSMakePoint(

NSMaxX([browser_view bounds]) - kAnchorlessEndPadding,

NSMaxY([browser_view bounds]) - kAnchorlessTopPadding);

- [[bubbleController_ bubble] setArrowLocation:info_bubble::kNoArrow];

+ [[bubbleController_ bubble] setArrowLocation:views::BubbleBorder::NONE];

if (base::i18n::IsRTL()) {

anchor_point.x = NSMaxX([anchor_view bounds]) - anchor_point.x;

[[bubbleController_ bubble] setAlignment: