chrome/browser/ui/cocoa/autofill/autofill_details_container.mm - Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_details_container.mm

Issue 1162393003: Replace info_bubble::BubbleArrowLocation with views::BubbleBorder::Arrow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile in test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/autofill/autofill_main_container.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_details_container.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_details_container.mm b/chrome/browser/ui/cocoa/autofill/autofill_details_container.mm

index 1609fd21d39bbf32c692a861bdb72d9d6c15762a..571abdd277f11d1c396a2a9a5dab50f1a738622b 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_details_container.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_details_container.mm

@@ -206,13 +206,15 @@ typedef BOOL (^FieldFilterBlock)(NSView<AutofillInputField>*);

if ((NSMinX(viewRect) + [errorBubbleController_ maxWidth]) >

NSWidth([parentWindow frame])) {

anchorPoint = NSMakePoint(NSMaxX(viewRect), NSMinY(viewRect));

- [[errorBubbleController_ bubble] setArrowLocation:info_bubble::kTopRight];

+ [[errorBubbleController_ bubble]

+ setArrowLocation:views::BubbleBorder::TOP_RIGHT];

[[errorBubbleController_ bubble] setAlignment:

info_bubble::kAlignRightEdgeToAnchorEdge];

} else {

anchorPoint = NSMakePoint(NSMinX(viewRect), NSMinY(viewRect));

- [[errorBubbleController_ bubble] setArrowLocation:info_bubble::kTopLeft];

+ [[errorBubbleController_ bubble]

+ setArrowLocation:views::BubbleBorder::TOP_LEFT];

[[errorBubbleController_ bubble] setAlignment:

info_bubble::kAlignLeftEdgeToAnchorEdge];

}