Issue 1162393002: Simplify TransferMode and Color types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162393002: Simplify TransferMode and Color types. (Closed)

Created:
5 years, 6 months ago by Matt Perry

Modified:
5 years, 6 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Simplify TransferMode and Color types. They are no longer wrappers in C++, but are converted directly to their Skia types. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9e3bbc1981d932b817b0adba64c95990962a7f8b

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -53 lines)			Patch
M	sky/engine/bindings/scripts/dart_types.py	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	sky/engine/core/painting/CanvasColor.h	View	1	1 chunk	+7 lines, -10 lines	0 comments	Download
M	sky/engine/core/painting/CanvasColor.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	sky/engine/core/painting/ColorFilter.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/painting/ColorFilter.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sky/engine/core/painting/DrawLooperLayerInfo.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/painting/Paint.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	sky/engine/core/painting/Point.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/painting/Point.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/painting/Rect.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/painting/Rect.cpp	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	sky/engine/core/painting/TransferMode.h	View	1	1 chunk	+6 lines, -9 lines	0 comments	Download
M	sky/engine/core/painting/TransferMode.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Matt Perry

Turns out I was lying about not being able to typedef TransferMode.

5 years, 6 months ago (2015-06-02 22:03:07 UTC) #2

Matt Perry

5 years, 6 months ago (2015-06-03 17:33:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9e3bbc1981d932b817b0adba64c95990962a7f8b (presubmit successful).