Make some editing/selection functions accessible to c/b/renderer_host/

content/browser/frame_host/interstitial_page_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 11 matching lines @@
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_delegate_view.h"
 #include "content/browser/renderer_host/render_view_host_factory.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/browser/web_contents/web_contents_view.h"
 #include "content/common/frame_messages.h"
+#include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/dom_operation_notification_details.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/storage_partition.h"
@@ skipping 377 matching lines @@
   controller_->delegate()->NotifyNavigationStateChanged(INVALIDATE_TYPE_TITLE);
 }
 
 AccessibilityMode InterstitialPageImpl::GetAccessibilityMode() const {
   if (web_contents_)
     return static_cast<WebContentsImpl*>(web_contents_)->GetAccessibilityMode();
   else
     return AccessibilityModeOff;
 }
 
+void InterstitialPageImpl::Cut() {
+  FrameTreeNode* focused_node = frame_tree_.GetFocusedFrame();
+  RenderFrameHostImpl* focused_frame =
+      focused_node ? focused_node->current_frame_host() : nullptr;
+  if (!focused_frame)

[dcheng, 2015/06/29 17:58:02]

Question: can you have a situation where focused_node != nullptr and
focused_frame == nullptr?

If not, I think it'd be clearer to rewrite this as:
FrameTreeNode* focused_node = ...;
if (!focused_node) return;
RenderFrameHostImpl* focused_frame = focused_node->current_frame_host();

[mohsen, 2015/06/29 21:46:53]

This is the case I saw in tests and that's why I explicitly set focused frame in
my interstitial browser test. However, it appears to me that it should not be
the case (based on other places that FrameTreeNode::current_frame_host() is
used). So, changed it to your suggestion.

+    return;
+
+  focused_frame->Send(new InputMsg_Cut(focused_frame->GetRoutingID()));
+  RecordAction(base::UserMetricsAction("Cut"));
+}
+
+void InterstitialPageImpl::Copy() {
+  FrameTreeNode* focused_node = frame_tree_.GetFocusedFrame();
+  RenderFrameHostImpl* focused_frame =
+      focused_node ? focused_node->current_frame_host() : nullptr;
+  if (!focused_frame)
+    return;
+
+  focused_frame->Send(new InputMsg_Copy(focused_frame->GetRoutingID()));
+  RecordAction(base::UserMetricsAction("Copy"));
+}
+
+void InterstitialPageImpl::Paste() {
+  FrameTreeNode* focused_node = frame_tree_.GetFocusedFrame();
+  RenderFrameHostImpl* focused_frame =
+      focused_node ? focused_node->current_frame_host() : nullptr;
+  if (!focused_frame)
+    return;

[dcheng, 2015/06/29 17:58:02]

It almost seems like we should have a helper for this. How common will this
pattern be?

[mohsen, 2015/06/29 21:46:53]

Not applicable, anymore, I guess.

+
+  focused_frame->Send(new InputMsg_Paste(focused_frame->GetRoutingID()));
+  RecordAction(base::UserMetricsAction("Paste"));
+}
+
 RenderViewHostDelegateView* InterstitialPageImpl::GetDelegateView() {
   return rvh_delegate_view_.get();
 }
 
 const GURL& InterstitialPageImpl::GetMainFrameLastCommittedURL() const {
   return url_;
 }
 
 void InterstitialPageImpl::RenderViewTerminated(
     RenderViewHost* render_view_host,
@@ skipping 458 matching lines @@
 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted(
     const LoadCommittedDetails& load_details) {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
   interstitial_->OnNavigatingAwayOrTabClosing();
 }
 
 }  // namespace content