src/objects.cc - Issue 1162363005: Remove usage of to-be-deprecated APIs from v8 core

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1162363005: Remove usage of to-be-deprecated APIs from v8 core (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 2390802777914bfe9b110c9e724b47a76f6bdb76..b0222f660f79d6adb3d8e75d3210133353bb96f6 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -4290,7 +4290,9 @@ Maybe<PropertyAttributes> JSObject::GetPropertyAttributesWithInterceptor(

}

if (!result.IsEmpty()) {

DCHECK(result->IsInt32());

- return Just(static_cast<PropertyAttributes>(result->Int32Value()));

+ return Just(static_cast<PropertyAttributes>(

+ result->Int32Value(reinterpret_cast<v8::Isolate*>(isolate)

+ ->GetCurrentContext()).FromJust()));

}

} else if (!interceptor->getter()->IsUndefined()) {

// TODO(verwaest): Use GetPropertyWithInterceptor?

« no previous file with comments | « src/full-codegen.cc ('k') | src/runtime/runtime-test.cc » ('j') | no next file with comments »