Issue 1162333005: Revert of Chromecast: Cma should has_audio/video after initialization finishes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162333005: Revert of Chromecast: Cma should has_audio/video after initialization finishes. (Closed)

Created:
5 years, 6 months ago by gunsch

Modified:
5 years, 6 months ago

Reviewers:
lcwu1, damienv1, servolk

CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, gunsch+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Chromecast: Cma should has_audio/video after initialization finishes. (patchset #1 id:1 of https://codereview.chromium.org/1125033003/) Reason for revert: This wasn't the right fix. It was reverted downstream but not upstream. Original issue's description: > Chromecast: Cma should has_audio/video after initialization finishes. > > R=lcwu@chromium.org,servolk@chromium.org,damienv@chromium.org > BUG=internal b/19868692 > > Committed: https://crrev.com/23b6c79d53147e704074c624bc6326bef4933ba4 > Cr-Commit-Position: refs/heads/master@{#329949} TBR=damienv@chromium.org,lcwu@chromium.org,servolk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=internal b/19868692 Committed: https://crrev.com/db78c310547225f966270178bbadf1303e6b7be8 Cr-Commit-Position: refs/heads/master@{#333132}

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chromecast/media/cma/filters/cma_renderer.cc	View		4 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

gunsch

Created Revert of Chromecast: Cma should has_audio/video after initialization finishes.

5 years, 6 months ago (2015-06-05 21:13:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162333005/1

5 years, 6 months ago (2015-06-05 21:14:19 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 21:16:41 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/db78c310547225f966270178bbadf1303e6b7be8
Cr-Commit-Position: refs/heads/master@{#333132}