Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: Tools/Scripts/webkitpy/w3c/test_converter_unittest.py

Issue 1162333004: W3C test_converter.py fails to prefix if previous declaration does not have ";" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/w3c/test_converter.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
diff --git a/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py b/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
index 8503993b399c99888607e58d0bb04a96efebd220..0a299f8560db45623c4494f70ade88b4035b8c5e 100755
--- a/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
+++ b/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
@@ -239,6 +239,7 @@ CONTENT OF TEST
""" Tests convert_prefixed_properties() file that has 20 properties requiring the -webkit- prefix:
10 in one style block + 5 in another style
block + 5 inline styles, including one with multiple prefixed properties.
+ 2 when prefixed properties appear in comments without ending ';'.
The properties in the test content are in all sorts of wack formatting.
"""
@@ -295,11 +296,16 @@ CONTENT OF TEST
@test19@: propvalue;
}
+#missing-semicolon-in-comments {
+ /* @test20@: propvalue */
+ @test21@: propvalue;
+}
+
]]></style>
</html>
"""
converter = _W3CTestConverter(DUMMY_PATH, DUMMY_FILENAME, None)
- test_content = self.generate_test_content(converter.prefixed_properties, 20, test_html)
+ test_content = self.generate_test_content(converter.prefixed_properties, 22, test_html)
oc = OutputCapture()
oc.capture_output()
« no previous file with comments | « Tools/Scripts/webkitpy/w3c/test_converter.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698