Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1162333004: W3C test_converter.py fails to prefix if previous declaration does not have ";" (Closed)

Created:
4 years, 11 months ago by kojii
Modified:
4 years, 11 months ago
Reviewers:
tkent, Dirk Pranke, jsbell, joelo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

W3C test_converter.py fails to prefix if previous declaration does not have ";" When test_converter.py started to prefix values, it assumed that there will be a ";" to end the declaration. This isn't the case if invalid syntax, or when the property name appear in comments. Since all cases it handles today is a sipmle single value, this patch changes the regex to find a word, instead of all text up to ";". This change fixes the following tests: imported/csswg-test/css-writing-modes-3/line-box-direction-019.xht imported/csswg-test/css-writing-modes-3/line-box-direction-020.xht BUG=492664 TEST=Tools/Scripts/webkitpy/w3c/test_converter_unittest.py Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/w3c/test_converter.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kojii
PTAL.
4 years, 11 months ago (2015-06-04 07:13:59 UTC) #2
tkent
lgtm
4 years, 11 months ago (2015-06-04 07:19:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162333004/1
4 years, 11 months ago (2015-06-04 10:54:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196490
4 years, 11 months ago (2015-06-04 10:57:11 UTC) #6
Dirk Pranke
4 years, 11 months ago (2015-06-04 20:31:58 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698