Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1162333003: Added supporting code for Blink layout tests for isContentRichlyEditable. (Closed)

Created:
5 years, 6 months ago by nektarios
Modified:
5 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added supporting code for Blink layout tests for isContentRichlyEditable. Related to issue 1156353003. BUG=491027 R=dmazzoni Committed: https://crrev.com/f57a948e0db39e4301676d45646800c770c9fc56 Cr-Commit-Position: refs/heads/master@{#333614}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Renamed isContentRichlyEditable to isRichlyEditable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/test_runner/web_ax_object_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/web_ax_object_proxy.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
nektarios
5 years, 6 months ago (2015-06-04 01:26:43 UTC) #1
dmazzoni
lgtm FYI: test_runner just moved to a new directory today - git rebase should figure ...
5 years, 6 months ago (2015-06-04 03:37:52 UTC) #2
dmazzoni
I'd slightly prefer isRichlyEditable but I don't care too strongly either way. Make it consistent ...
5 years, 6 months ago (2015-06-04 03:38:31 UTC) #3
chromium-reviews
Renamed to isRichlyEditable. To unsubscribe from this group and stop receiving emails from it, send ...
5 years, 6 months ago (2015-06-04 19:14:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162333003/40001
5 years, 6 months ago (2015-06-09 21:37:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-09 22:44:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162333003/40001
5 years, 6 months ago (2015-06-09 23:54:19 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-10 00:00:50 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 00:01:49 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f57a948e0db39e4301676d45646800c770c9fc56
Cr-Commit-Position: refs/heads/master@{#333614}

Powered by Google App Engine
This is Rietveld 408576698