Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: ui/webui/resources/js/cr/ui/focus_outline_manager.js

Issue 1162293008: Fix some lingering WebUI focus issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: not more or less hacky, just hacky in a different way... Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/js/cr/ui/focus_outline_manager.js
diff --git a/ui/webui/resources/js/cr/ui/focus_outline_manager.js b/ui/webui/resources/js/cr/ui/focus_outline_manager.js
index df8dadc24ecc2d3ab0eb6b244d372908cea1ffda..5a8ed8e81deb6fc97e20baa1d9a96971a78d7be3 100644
--- a/ui/webui/resources/js/cr/ui/focus_outline_manager.js
+++ b/ui/webui/resources/js/cr/ui/focus_outline_manager.js
@@ -41,19 +41,19 @@ cr.define('cr.ui', function() {
doc.addEventListener('focus', function(event) {
// Update visibility only when focus is actually changed.
- self.updateVisiblity_();
+ self.updateVisibility();
}, true);
doc.addEventListener('focusout', function(event) {
window.setTimeout(function() {
if (!doc.hasFocus()) {
self.focusByKeyboard_ = true;
- self.updateVisiblity_();
+ self.updateVisibility();
}
}, 0);
});
- this.updateVisiblity_();
+ this.updateVisibility();
}
FocusOutlineManager.prototype = {
@@ -64,8 +64,7 @@ cr.define('cr.ui', function() {
*/
focusByKeyboard_: true,
- /** @private */
- updateVisiblity_: function() {
+ updateVisibility: function() {
this.visible = this.focusByKeyboard_;
},

Powered by Google App Engine
This is Rietveld 408576698