chrome/browser/resources/extensions/pack_extension_overlay.js - Issue 1162293008: Fix some lingering WebUI focus issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/pack_extension_overlay.js

Issue 1162293008: Fix some lingering WebUI focus issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: not more or less hacky, just hacky in a different way... Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/extensions/pack_extension_overlay.js

diff --git a/chrome/browser/resources/extensions/pack_extension_overlay.js b/chrome/browser/resources/extensions/pack_extension_overlay.js

index 03e6180a03d4400aa99369f9788a749edefdf954..05d23d1f2f9062f45b793b868a267d4e46d9f867 100644

--- a/chrome/browser/resources/extensions/pack_extension_overlay.js

+++ b/chrome/browser/resources/extensions/pack_extension_overlay.js

@@ -23,8 +23,9 @@ cr.define('extensions', function() {

cr.ui.overlay.globalInitialization();

overlay.addEventListener('cancelOverlay', this.handleDismiss_.bind(this));

- $('pack-extension-dismiss').addEventListener('click',

- this.handleDismiss_.bind(this));

+ $('pack-extension-dismiss').addEventListener('click', function() {

+ cr.dispatchSimpleEvent(overlay, 'cancelOverlay');

+ });

$('pack-extension-commit').addEventListener('click',

this.handleCommit_.bind(this));

$('browse-extension-dir').addEventListener('click',