chrome/browser/resources/extensions/extension_error_overlay.js - Issue 1162293008: Fix some lingering WebUI focus issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_error_overlay.js

Issue 1162293008: Fix some lingering WebUI focus issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: not more or less hacky, just hacky in a different way... Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/extensions/extension_error_overlay.js

diff --git a/chrome/browser/resources/extensions/extension_error_overlay.js b/chrome/browser/resources/extensions/extension_error_overlay.js

index 84e32a9f63bb0fbf8b6f988b74978a0f683b93de..1f7975e6605c39366ae46d65b64c9953838df136 100644

--- a/chrome/browser/resources/extensions/extension_error_overlay.js

+++ b/chrome/browser/resources/extensions/extension_error_overlay.js

@@ -292,8 +292,10 @@ cr.define('extensions', function() {

cr.ui.overlay.globalInitialization();

overlay.addEventListener('cancelOverlay', this.handleDismiss_.bind(this));

- $('extension-error-overlay-dismiss').addEventListener(

- 'click', this.handleDismiss_.bind(this));

+ $('extension-error-overlay-dismiss').addEventListener('click',

+ function() {

+ cr.dispatchSimpleEvent(overlay, 'cancelOverlay');

+ });

/**

* The element of the full overlay.